🎨 Enhance readability of CS current plots and improve label forma… - #4556
🎨 Enhance readability of CS current plots and improve label forma…#4556chris-ashe wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4556 +/- ##
=======================================
Coverage 49.46% 49.46%
=======================================
Files 150 150
Lines 30069 30079 +10
=======================================
+ Hits 14874 14879 +5
- Misses 15195 15200 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
left a comment
clmould
left a comment
There was a problem hiding this comment.
Also, the 'System power over time' plot still has some overlapping labels, can this be fixed please as both are mentioned in the original issue
| axis.set_ylabel("Current [A]", fontsize=12) | ||
|
|
||
| # Add a title | ||
| axis.set_title("Current Profiles Over Time", fontsize=14) |
There was a problem hiding this comment.
Could this title be added back please, and some axis titles if possible/appropriate for each plot
| ], # Exclude the last label as it corresponds to the dwell period | ||
| rotation=60, | ||
| ) | ||
| # Stagger adjacent labels onto two rows so closely spaced pulse events remain |
There was a problem hiding this comment.
I'm not sure the new x axis labels look any different?
Old on left, new on right:
There was a problem hiding this comment.
The current plot now has a linear scale - OK.
There was a problem hiding this comment.
I would have thought the power plot should also be plotted using a linear scale. @chris-ashe
There was a problem hiding this comment.
@mkovari Thinking that the power plot will need to be split into two as well if its going to be linear, the value range scale currently makes most values unreadable in linear scale
| axis.grid(True, linestyle="--", alpha=0.6) | ||
| axis.axhline(0, color="black", linewidth=2) | ||
| axis.tick_params(axis="x", labelbottom=False) | ||
| axis.set_ylabel("Current [A]", fontsize=12) |
There was a problem hiding this comment.
Could a time label be added so both x axes have that ?
There was a problem hiding this comment.
The axes are currently using sharex so they are both aligned numerically with the same x-axis given in the lower plot
| t_plant_pulse_dwell=mfile.get("t_plant_pulse_dwell", scan=scan), | ||
| ) | ||
|
|
||
| try: |
There was a problem hiding this comment.
This is causing a pre-commit failure, could you fix that please?
| secax.tick_params(axis="x", which="major") | ||
|
|
||
| # Add axis labels | ||
| axis.set_xlabel("Time [s]", fontsize=12) |
There was a problem hiding this comment.
This seems to be misaligned with the x axis, could that be fixed please
4 participants
Description
Checklist
I confirm that I have completed the following checks: