Repository navigation
Allow configuring Python SDK retry methods - #53
glenn-jocher merged 1 commit into
Conversation
|
👋 Hello @JaviChulvi, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the retry_methods propagation, default behavior, sync/async generated clients, retry predicate, documentation, and existing generator patterns. The default GET/HEAD/OPTIONS behavior is preserved, existing JSON 429 retries remain intact, and the opt-in method configuration is API-independent. LGTM; no concrete defects found.
Allow callers to opt safe-to-repeat methods into the existing Python SDK retry loop with
retry_methods=("POST",). Defaults stay unchanged. This lets training metrics and checkpoint signing reuse SDK retries instead of maintaining another retry loop in Ultralytics. The generator remains API-independent.Merge this first so SDK automation can generate and publish the updated client. Then ultralytics/ultralytics#26190 can use it.
Validated with generator checks, sync/async SDK tests, and live local-training, upload, and cancellation E2E.