CLDR-19548 Remove mil and add milliinch by macchiati · Pull Request #5977 · unicode-org/cldr

macchiati · 2026-07-30T04:27:12Z

CLDR-19548

This PR completes the ticket.

ALLOW_MANY_COMMITS=true

srl295 · 2026-07-31T02:22:32Z

Looks ok, but

the java settings could go against CLDR-19326 deps: JDK 21 (CLDR-19326 deps: JDK 21 #5845) instead - want me to split this into another pr?
"mil" is in the incoming vxml, so this will just break again when that merges.

macchiati · 2026-07-31T04:10:43Z

Yes, splitting this would be good.

Merging this should also wait until the vxml is in.

robertbastian · 2026-07-31T09:46:55Z

        <!-- length -->
-        <convertUnit source='mil' baseUnit='meter' factor='ft_to_m/12*1000' systems="ussystem uksystem"/>
        <convertUnit source='point' baseUnit='meter' factor='ft_to_m/864' systems="metric_adjacent ussystem uksystem"/>
        <convertUnit source='inch' baseUnit='meter' factor='ft_to_m/12' systems="ussystem uksystem"/>


I think we need to set "prefixable" on inch

Prefixable is not a hard requirement; the goal is to indicate that typically the prefixes are used with the unit. In the case of the inch, it isn't really typical. The wording is the following; if we need improvements we should discuss that. (Sorry for not attending to this comment earlier.)

"Those units that typically use SI prefixes or the IEC binary prefixes. This can include measures like parsec that are not SI units. It allows implementations to group those units together, and to do sanity checks on the prefix+unit combinations, if they choose. However, implementations may choose to allow prefixes on other units, especially since there is a significant variance in usage: even a term like megafoot might be acceptable in some contexts."

robertbastian · 2026-07-31T09:48:03Z

"mil" is in the incoming vxml, so this will just break again when that merges.

It's just in root and en, which didn't change in vxml. It should be a clean merge.

srl295 · 2026-07-31T16:36:50Z

"mil" is in the incoming vxml, so this will just break again when that merges.

It's just in root and en, which didn't change in vxml. It should be a clean merge.

But there are translations in sub locales for mil that will just become invalid

Anyway I can fix up vxml once this merges

macchiati · 2026-07-31T19:07:24Z

I'm going to change to draft until vxml is merged. I can't right now because I'm not at my computer.

…

On Fri, Jul 31, 2026, 09:58 Steven R. Loomis ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#5977?email_source=notifications&email_token=ACJLEMFY6RR6UIF6FBJAUAT5HTF27A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBTGA2TQMZTHAZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4830583383>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMDE65SRGLRDYTIPFQL5HTF27AVCNFSNUABFKJSXA33TNF2G64TZHMYTAMZZGQ4DMNZSHNEXG43VMU5TKMBRGYYTGMZSGY3KC5QC> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/ACJLEMACVPDUSYQLKZ7YYLT5HTF27A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBTGA2TQMZTHAZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/ACJLEMHIRQNKEZQRVYWRHMD5HTF27A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBTGA2TQMZTHAZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you were assigned.Message ID: ***@***.***>

macchiati · 2026-08-03T01:04:04Z

the java settings could go against CLDR-19326 deps: JDK 21 (#5845) instead - want me to split this into another pr?

I fixed this, and a dangling reference to 'mil'.
The data for mil needs to be transferred once we have vxml merged.

macchiati · 2026-08-03T01:04:35Z

Converting to draft so it doesn't get merged prematurely.

srl295 · 2026-08-03T19:11:26Z

VXML is now merged.

List of files with `length-mil` in main now

common/main/en.xml:			<unit type="length-mil">
common/main/en.xml-				<displayName>mils</displayName>
--
common/main/en.xml:			<unit type="length-mil">
common/main/en.xml-				<displayName>mil</displayName>
--
common/main/en.xml:			<unit type="length-mil">
common/main/en.xml-				<displayName>mil</displayName>
--
common/main/en_CA.xml:			<unit type="length-mil">
common/main/en_CA.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_CA.xml:			<unit type="length-mil">
common/main/en_CA.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_CA.xml:			<unit type="length-mil">
common/main/en_CA.xml-				<displayName>↑↑↑</displayName>
--
common/main/root.xml:			<unit type="length-mil">
common/main/root.xml-				<displayName>mil [US]</displayName>
--
common/main/en_AU.xml:			<unit type="length-mil">
common/main/en_AU.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_AU.xml:			<unit type="length-mil">
common/main/en_AU.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_AU.xml:			<unit type="length-mil">
common/main/en_AU.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_IN.xml:			<unit type="length-mil">
common/main/en_IN.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_IN.xml:			<unit type="length-mil">
common/main/en_IN.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_IN.xml:			<unit type="length-mil">
common/main/en_IN.xml-				<displayName>↑↑↑</displayName>
--
common/main/cv.xml:			<unit type="length-mil">
common/main/cv.xml-				<displayName>мил</displayName>
--
common/main/cv.xml:			<unit type="length-mil">
common/main/cv.xml-				<displayName>мил</displayName>
--
common/main/cv.xml:			<unit type="length-mil">
common/main/cv.xml-				<displayName>мил</displayName>
--
common/main/en_GB.xml:			<unit type="length-mil">
common/main/en_GB.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_GB.xml:			<unit type="length-mil">
common/main/en_GB.xml-				<displayName>↑↑↑</displayName>
--
common/main/en_GB.xml:			<unit type="length-mil">
common/main/en_GB.xml-				<displayName>↑↑↑</displayName>

The above will need to be fixed or they will error, Chuvash is the only one who put in a new translation.

jira-pull-request-webhook · 2026-08-03T21:21:27Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati · 2026-08-03T21:32:51Z

I rebased on main, then just checked, and no other locales need to change (none of them had <unit type="length-mil">. So if the tests pass we're cool.

srl295

what's here LGTM but still failing tests

srl295 · 2026-08-03T23:49:16Z

I rebased on main, then just checked, and no other locales need to change (none of them had <unit type="length-mil">. So if the tests pass we're cool.

not what i'm seeing in this PR:

16 results - 6 files

common/main/cv.xml:
  22892  			</unit>
  22893: 			<unit type="length-mil">
  22894  				<displayName>мил</displayName>

  24421  			</unit>
  24422: 			<unit type="length-mil">
  24423  				<displayName>мил</displayName>

  25950  			</unit>
  25951: 			<unit type="length-mil">
  25952  				<displayName>мил</displayName>

common/main/en_AU.xml:
   8309  			</unit>
   8310: 			<unit type="length-mil">
   8311  				<displayName>↑↑↑</displayName>

   9628  			</unit>
   9629: 			<unit type="length-mil">
   9630  				<displayName>↑↑↑</displayName>

  10947  			</unit>
  10948: 			<unit type="length-mil">
  10949  				<displayName>↑↑↑</displayName>

common/main/en_CA.xml:
   7890  			</unit>
   7891: 			<unit type="length-mil">
   7892  				<displayName>↑↑↑</displayName>

   9207  			</unit>
   9208: 			<unit type="length-mil">
   9209  				<displayName>↑↑↑</displayName>

  10524  			</unit>
  10525: 			<unit type="length-mil">
  10526  				<displayName>↑↑↑</displayName>

common/main/en_GB.xml:
   9049  			</unit>
   9050: 			<unit type="length-mil">
   9051  				<displayName>↑↑↑</displayName>

  10368  			</unit>
  10369: 			<unit type="length-mil">
  10370  				<displayName>↑↑↑</displayName>

  11687  			</unit>
  11688: 			<unit type="length-mil">
  11689  				<displayName>↑↑↑</displayName>

common/main/en_IN.xml:
   7984  			</unit>
   7985: 			<unit type="length-mil">
   7986  				<displayName>↑↑↑</displayName>

   9303  			</unit>
   9304: 			<unit type="length-mil">
   9305  				<displayName>↑↑↑</displayName>

  10622  			</unit>
  10623: 			<unit type="length-mil">
  10624  				<displayName>↑↑↑</displayName>

common/supplemental/coverageLevels.xml:
  175  		<coverageVariable key="%unitLengths" value="(long|short|narrow)"/>
  176: 		<coverageVariable key="%unitsEnglish" value="(force-dyne|force-poundal|length-fathom|length-mil|length-furlong|mass-stone|volume-bushel|energy-british-thermal-unit|volume-pint-imperial|volume-cup-imperial|temperature-rankine|mass-slug|pressure-gasoline-energy-density|energy-british-thermal-unit-it|length-rod|length-chain|duration-fortnight)"/>
  177  		<coverageVariable key="%unitsJapanese" value="(area-bu-jp|area-cho|area-se-jp|length-jo-jp|length-ken|length-ri-jp|length-rin|length-shaku-cloth|length-shaku-length|length-sun|mass-fun|volume-cup-jp|volume-koku|volume-kosaji|volume-osaji|volume-sai|volume-shaku|volume-to-jp)"/>

srl295 · 2026-08-03T23:56:02Z

@macchiati see and merge #6009 if LGTU

(Note: I didn't make it a stack! 🥞 )

srl295 · 2026-08-04T00:01:12Z

Err, fixing

srl295 · 2026-08-04T01:59:55Z

    testCoverage {
      Error: (TestUnits.java:2478) : en Modern ⊇ VALID_REGULAR_UNITS: expected java.util.Collections$EmptySet<[]>, got java.util.LinkedHashSet<[milliinch, poundal, dyne]>
      Error: (TestUnits.java:2478) : de Modern ⊇ VALID_REGULAR_UNITS: expected java.util.Collections$EmptySet<[]>, got java.util.LinkedHashSet<[milliinch]>

I am getting that locally

srl295 · 2026-08-04T02:00:54Z

                        "sai",
                        "shaku",
                        "to-jp",
-                        "mil",


@macchiati should this have milliinch added?

I'll look it over later today.

robertbastian · 2026-08-04T07:29:01Z

@macchiati did you see my comment?

robertbastian

.

srl295 · 2026-08-04T13:22:29Z

@macchiati did you see my comment?

#5977 (review) i assume?

github-actions Bot assigned macchiati Jul 30, 2026

AEApple reviewed Jul 30, 2026

View reviewed changes

Comment thread common/main/root.xml Outdated

macchiati requested review from AEApple, robertbastian and stenshamn July 30, 2026 17:32

macchiati marked this pull request as ready for review July 30, 2026 17:32

robertbastian reviewed Jul 31, 2026

View reviewed changes

srl295 previously approved these changes Jul 31, 2026

View reviewed changes

macchiati dismissed srl295’s stale review via 91fb30a August 3, 2026 01:02

macchiati marked this pull request as draft August 3, 2026 01:04

macchiati added 3 commits August 3, 2026 14:21

CLDR-19548 Remove mil and add milliinch

d2120fe

CLDR-19548 Remove the "[US]"

9ee40f2

CLDR-19548 Cleanup

43403ae

macchiati force-pushed the CLDR-19548-Remove-mil-and-add-milliinch branch from 91fb30a to 43403ae Compare August 3, 2026 21:21

macchiati marked this pull request as ready for review August 3, 2026 21:31

macchiati requested review from btangmu, robertbastian and srl295 August 3, 2026 21:32

srl295 previously approved these changes Aug 3, 2026

View reviewed changes

srl295 mentioned this pull request Aug 3, 2026

CLDR-19548 Further remove mil and add milliinch #6009

Merged

1 task

CLDR-19548 Further remove mil and add milliinch (#6009)

066bfd7

macchiati dismissed srl295’s stale review via 066bfd7 August 4, 2026 01:40

srl295 reviewed Aug 4, 2026

View reviewed changes

robertbastian reviewed Aug 4, 2026

View reviewed changes

CLDR-19548 Fix coverage test for milliinch

59953fb

macchiati requested review from robertbastian and srl295 August 8, 2026 01:14

srl295 approved these changes Aug 8, 2026

View reviewed changes

macchiati merged commit fa4596a into main Aug 8, 2026
12 checks passed

macchiati deleted the CLDR-19548-Remove-mil-and-add-milliinch branch August 8, 2026 03:51

Uh oh!

Conversation

macchiati commented Jul 30, 2026

Uh oh!

Uh oh!

srl295 commented Jul 31, 2026

Uh oh!

macchiati commented Jul 31, 2026

Uh oh!

robertbastian Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

macchiati Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

robertbastian commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srl295 commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macchiati commented Jul 31, 2026 via email

Uh oh!

macchiati commented Aug 3, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macchiati commented Aug 3, 2026

Uh oh!

srl295 commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jira-pull-request-webhook Bot commented Aug 3, 2026

Uh oh!

macchiati commented Aug 3, 2026 • edited by srl295 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srl295 left a comment

Choose a reason for hiding this comment

Uh oh!

srl295 commented Aug 3, 2026

Uh oh!

srl295 commented Aug 3, 2026

Uh oh!

srl295 commented Aug 4, 2026

Uh oh!

srl295 commented Aug 4, 2026

Uh oh!

srl295 Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

macchiati Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

robertbastian commented Aug 4, 2026

Uh oh!

robertbastian left a comment

Choose a reason for hiding this comment

Uh oh!

srl295 commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

robertbastian commented Jul 31, 2026 •

edited

Loading

srl295 commented Jul 31, 2026 •

edited

Loading

macchiati commented Aug 3, 2026 •

edited by atlassian Bot

Loading

srl295 commented Aug 3, 2026 •

edited

Loading

macchiati commented Aug 3, 2026 •

edited by srl295

Loading