CLDR-19662 Fix ordinal dates

[macchiati]

CLDR-19662

• Adds tooling to figure out what to do

  • FixOrdinalDates.java, SplitPath.java

• Removes paths with /dayOfMonth and ddd from locales (but not en|en_AU|en_CA|en_GB|en_IN|fr|fr_CA|hy|ka|mk|or|tk|uk)

  • but leaves calendar aliases in root.
  • made manual spot fixes to one path in each of de, ky, sk, zh_Hant, to fix cases with ddd in pattern but not in skeleton

• Adds modifications to coverageLevels.xml for coverage, and a small bit of syntax to allow for much simpler rules.

• Also checks in modify_config.txt, for a paper trail.

• tools/cldr-code/src/main/java/org/unicode/cldr/tool/CLDRConfigFileFilter.java

  • Ran into a problem where CLDRModify wasn't working right. The problem was a trailing ';'. So made fixes to address that for the future (since it could surprise others as well).

• Modifications in other code files were all about getting coverage to work better.

• This PR completes the ticket.

ALLOW_MANY_COMMITS=true

[macchiati]

I think the work is mostly done, but will have to get the tests to pass.

[AEApple]

JFY: Waiting to review this until it passes all tests

[macchiati]

This is disturbing; all the tests pass locally for me. Will have to track down.

[macchiati]

Hmmm. I can't reproduce the test failures locally; I'll have some time later this afternoon. However, I think what I'll do for dates is add the pattern that the spec algorithm would produce (if any), and if that succeeds, count it as covered.

[srl295]

This is disturbing; all the tests pass locally for me. Will have to track down.

Your branch is 8 commits behind main. e38dbeb That could be related. The pull_request build builds against the latest main, with your PR on top.

[srl295]

@macchiati fails for me locally also, even without an update. were you running -e10?

    TestAllLocales {
      Error: (TestCheckCLDR.java:506) : en_CA //ldml/dates/calendars/calendar[@type="generic"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMMddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : en_CA //ldml/dates/calendars/calendar[@type="generic"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMEddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="GyMMMddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMMddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMEddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMMEddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="GyMMMEddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="GyMMMMddd"]: expected != null
      Error: (TestCheckCLDR.java:506) : or //ldml/dates/calendars/calendar[@type="gregorian"]/dateTimeFormats/availableFormats/dateFormatItem[@id="GyMMMMEddd"]: expected != null

[macchiati]

Ah, that must be the problem!

[srl295]

Should this be an error? Or is it just an OK fallback?

Are you removing a “vote for constructed” essentially?

just trying to understand

[srl295]

Was this also an error for them to enter? Or fallback behavior?

[srl295]

Looks good but have questions.

[macchiati]

Sigh, now showing errors like the following, even though de, root, etc don't have ddd's

Error: (TestCheckCLDR.java:506) Error: : de_CH //ldml/dates/calendars/calendar[@type="generic"]/dateTimeFormats/availableFormats/dateFormatItem[@id="MMMMddd"]: expected != null