Skip to content

fix(deps): upgrade sharp to ^0.35.4 (v3) - #339

Open
BleedingDev wants to merge 2 commits into
unjs:v3from
BleedingDev:fix/v3-sharp-0.35
Open

BleedingDev wants to merge 2 commits into
unjs:v3from
BleedingDev:fix/v3-sharp-0.35

Conversation

@BleedingDev

@BleedingDev BleedingDev commented Sep 27, 2026 •

Copy link
Copy Markdown

Sharp upgrade issue #327

Why the change

IPX 3 needs sharp 0.35.4 while preserving image modifiers and declaring the Node version that can load it.

Special things to note

  • The verified minimum is Node 20.10: Node 20.9 fails to parse sharp's import attributes, while 20.10 processes real images through both built formats.
  • Sharpening now uses the options API, preserving explicit sigma, flat/jagged parameters and disabling; the dynamic loader also returns the typed default factory.
  • All 64 tests pass with 8 existing skips, plus lint and CJS/ESM/declaration builds; raw TypeScript checking still reports unchanged external and storage declaration errors.

Change outline

 dependencies.sharp
-  ^0.34.4
+  ^0.35.4

 engines.node
-  no minimum
+  >=20.10.0

 sharpen modifier
-  sharpen(sigma, flat, jagged)
+  sharpen({ sigma, m1: flat, m2: jagged })
+  false -> preserve the unchanged pipeline

Sharp 0.35 drops the install script, so a global libvips no longer
triggers a source build. It requires Node >=20.9, recorded in engines.

Closes unjs#327

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@BleedingDev
BleedingDev requested a review from pi0 as a code owner September 27, 2026 00:38
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6686a040-7d5b-40e8-a592-9a22d8bd7b5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant