Skip to content

upgrade python, update syntax, add pyproject - #39

Open
clarktr1 wants to merge 4 commits into
masterfrom
upgrade-python
Open

upgrade python, update syntax, add pyproject#39
clarktr1 wants to merge 4 commits into
masterfrom
upgrade-python

Conversation

@clarktr1

@clarktr1 clarktr1 commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

closes #37

@clarktr1

clarktr1 commented Sep 14, 2026

Copy link
Copy Markdown
Author

@somexpert @ldko This is ready for review.
The reason this doesn't support 3.9 is because of the pytest version. That version is what the other apps have been going to and for continuity that's the decision I made here. From a functional standpoint, the app works with 3.9.

Thoughts?

Note: this also needs to be updated on PyPI after we merge. 😄

ldko
ldko reviewed Sep 22, 2026
View reviewed changes

@ldko ldko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple changes requested. Thanks!

Comment thread README.md Outdated
Comment thread setup.py
Comment on lines -14 to -16
entry_points={
'console_scripts': ['edtf-validate=edtf_validate.valid_edtf:main'],
},

@ldko ldko Sep 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be brought over to pyproject.toml. See comment about project.scripts.

Comment thread pyproject.toml
ldko
ldko approved these changes Sep 23, 2026
View reviewed changes

@ldko ldko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes 👍

somexpert
somexpert reviewed Sep 30, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread requirements.txt
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment on lines 56 to 62

@somexpert somexpert Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we want to ditch PyPI in favor of installing straight from GitHub? Any thoughts on that @ldko? We'd need to make sure to update our requirements files for django-edtf, but that's no biggie.
Also, separate thought: should we also include instructions for local installation and/or running tests?

@somexpert somexpert Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go ahead and add a small section after "Installation" that says how to install the test dependencies and run the tests. Should only be a few added lines to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@somexpert somexpert somexpert left review comments
@ldko ldko ldko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set up with pyproject.toml

3 participants

@clarktr1 @somexpert @ldko