fix(legacy): handle null input in interactive prompt validators#86
Open
pjcdawkins wants to merge 2 commits into
Open
fix(legacy): handle null input in interactive prompt validators#86pjcdawkins wants to merge 2 commits into
pjcdawkins wants to merge 2 commits into
Conversation
Several interactive validator closures crashed with a TypeError when the
user pressed Enter to accept a null default:
- Selector::offerProjectChoice: explode(' - ', null) on the project-by-ID
prompt
- Selector::offerEnvironmentChoice: closure typed (string $value) with
nullable default $defaultEnvironmentId
- OrganizationCommandBase user picker: closure typed (string $email)
with null default
- TeamUserAddCommand: closure typed (string $value) with null default
- OrganizationUserAddCommand: optional permissions prompt calling
ArrayArgument::split([null]) -> preg_split(..., null)
Root cause: QuestionHelper::askInput returns mixed, and Symfony passes
null to the validator when the question's default is null. Type each
closure parameter as ?string and guard null explicitly.
In Selector::offerProjectChoice, also switch to
[$id] = explode(' - ', ..., 2) to avoid an "undefined array key 1"
warning when a project has no title (autocomplete value has no ' - ').
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens several legacy CLI interactive prompt validators against Symfony passing null when the question default is null and the user presses Enter, preventing TypeErrors in PHP 8+.
Changes:
- Update multiple
askInput()validator closures to accept?stringand explicitly handlenull. - Avoid
explode()warnings in project selection by limiting splits and safely handling null input. - Prevent
ArrayArgument::split()from receivingnullon optional permissions prompts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
legacy/src/Selector/Selector.php |
Makes project/environment prompt validators nullable-safe; improves project ID parsing. |
legacy/src/Command/Team/User/TeamUserAddCommand.php |
Makes interactive email validator nullable-safe. |
legacy/src/Command/Organization/User/OrganizationUserAddCommand.php |
Handles null optional permissions input safely before splitting. |
legacy/src/Command/Organization/OrganizationCommandBase.php |
Makes interactive email selection validator nullable-safe. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Distinguish "no input" from "invalid input" in two validators flagged by review on the parent PR: - TeamUserAddCommand: when the user presses Enter (null), report "An email address is required" instead of "Invalid email address:" (the original message also had no space after the colon). - Selector::offerEnvironmentChoice: when the user presses Enter and the default is null, report "An environment ID is required" instead of "Environment not found: " (empty). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #85 — fixes five more interactive prompts in the legacy CLI that crashed with a TypeError when the user pressed Enter to accept a null default. Tracked in CLI-143.
legacy/src/Selector/Selector.php(offerProjectChoice)explode(' - ', null)on the project-by-ID promptlegacy/src/Selector/Selector.php(offerEnvironmentChoice)(string $value)with nullable$defaultEnvironmentIdlegacy/src/Command/Organization/OrganizationCommandBase.php(string $email)with null defaultlegacy/src/Command/Team/User/TeamUserAddCommand.php(string $value)with null defaultlegacy/src/Command/Organization/User/OrganizationUserAddCommand.phpArrayArgument::split([null])→preg_split(..., null)on optional permissions promptRoot cause is the same as #85:
QuestionHelper::askInput()returnsmixed, and Symfony passesnullto the validator when the question's default is null. Per the long-term fix shape discussed on CLI-143, validator closures are now typed as?stringwith explicit null handling.In
Selector::offerProjectChoice, also switched to[$id] = explode(' - ', …, 2)to avoid an "undefined array key 1" warning when a project has no title (same improvement that addresses Copilot's comment on #85; the same pattern is fixed there in a follow-up).