fix(ps): return all host-visible PIDs via /proc walk#731
Open
Chennamma-Hotkar wants to merge 1 commit into
Open
fix(ps): return all host-visible PIDs via /proc walk#731Chennamma-Hotkar wants to merge 1 commit into
Chennamma-Hotkar wants to merge 1 commit into
Conversation
Previously ps only returned the monitor PID. Now getAllDescendants() recursively walks /proc/<pid>/task/<pid>/children to include all VMM sub-processes and virtiofsd in the output. Closes urunc-dev#637 Signed-off-by: Chennamma-Hotkar <channuhotkar@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
urunc psonly returned the sandbox monitor PID stored instate.json. This left VMM sub-processes (e.g. QEMU threads) and virtiofsd invisible to operators and container orchestrators, breaking cgroup accounting and process visibility.This PR adds
getAllDescendants()which recursively walks/proc/<pid>/task/<pid>/childrento collect all host-visible PIDsrooted at the monitor process. Since virtiofsd is spawned before
syscall.Exec(), it naturally becomes a child of the monitor PID and is included in the walk automatically.Related issues
How was this tested?
Unit tests added in
cmd/urunc/ps_test.go:TestGetAllDescendants_IncludesRoot— root PID is always presentTestGetAllDescendants_NonExistentPID— graceful handling of dead processTestGetAllDescendants_IncludesChild— spawned child process is detectedAll existing unit tests pass:
go test ./cmd/urunc/... ./pkg/unikontainers/... -short -timeout 60sTest Results
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).