Skip to content

CI: run checks before the browser download and cache Playwright browsers #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuanphungcz merged 1 commit into from
Oct 11, 2026
Merged

CI: run checks before the browser download and cache Playwright browsers #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
# One failing React version should not cancel the other.
fail-fast: false
matrix:
react: [18, 19]
steps:
Expand All @@ -45,10 +47,20 @@ jobs:
- run: npm ci
- if: matrix.react != 19
run: npm install --no-save react@${{ matrix.react }} react-dom@${{ matrix.react }} @types/react@${{ matrix.react }} @types/react-dom@${{ matrix.react }}
# The tests run in Chromium, Firefox and WebKit.
- run: npx playwright install --with-deps chromium firefox webkit
# Formatting, lint and type checks.
# Formatting, lint and type checks first, so they fail before the browser download.
- run: npm run check
# The tests run in Chromium, Firefox and WebKit. Browsers are cached per Playwright version.
- id: playwright
run: echo "version=$(node -p "require('playwright/package.json').version")" >> "$GITHUB_OUTPUT"
- id: playwright-cache
uses: actions/cache@v6
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ steps.playwright.outputs.version }}
- if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install --with-deps chromium firefox webkit
- if: steps.playwright-cache.outputs.cache-hit == 'true'
run: npx playwright install-deps chromium firefox webkit
- run: npm test
- if: matrix.react == 19
run: npm run build
Expand Down
Loading