Repository navigation
run-testbox: read the activity marker mtime with BSD stat on macOS - #17
Merged
Merged
Conversation
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
aayushshah15
marked this pull request as ready for review
October 24, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle loop read the activity marker's mtime with GNU
stat -c %Y. macOS ships BSDstat, which has no-c. Under the step'sbash -e, the first check afterblacksmith testbox runtouches~/.testbox-last-activitywould exit the job and kill a macOS Testbox.FILE_MTIME=$(stat -c %Y ~/.testbox-last-activity 2>/dev/null || stat -f %m ~/.testbox-last-activity)ssis also missing on macOS. That check sits in anifcondition, so it falls through to the marker file and doesn't abort the step. Reported in Pylon #15905.Need help on this PR? Tag
@codesmith-botwith what you need.With BSD-style stat and no ss, the old step dies with exit 1 at the first marker read. The new step reads the marker mtime through stat -f %m, keeps looping, and later shuts down normally on idle timeout with exit 0.
Merge-base
This PR
0da87a25Also checked · 2 match
Proof on
0da87a25Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)