feat: hide signup link from login when DISABLE_SIGNUPS is set#379
Open
taniasanz7 wants to merge 1 commit into
Open
feat: hide signup link from login when DISABLE_SIGNUPS is set#379taniasanz7 wants to merge 1 commit into
taniasanz7 wants to merge 1 commit into
Conversation
taniasanz7
force-pushed
the
patch-16-hide-signup-when-disabled
branch
from
c4c463f to
3c87cd3
Compare
Expose `signupsDisabled` on the public `GET /config` endpoint so the dashboard can reflect the API's `DISABLE_SIGNUPS` env flag. - Conditionally hide the "Sign up" link on the login page when signups are disabled, so visitors don't get routed to a form that always rejects with "New user signups are currently disabled". - Replace the signup form with a friendly "Signups are disabled" notice if a visitor navigates to /auth/signup directly. Pure UX patch. Does not change the signup endpoint's existing behavior (200 with success:false when disabled) and exposes only the signup-disabled flag - no secrets or admin-only env state.
taniasanz7
force-pushed
the
patch-16-hide-signup-when-disabled
branch
from
3c87cd3 to
1a68b68
Compare
Contributor
Author
|
@driaug if you see no value in this feel free to close; it's a tiny thing but thought it's a quick and simple UI/UX addition for self hosters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick follow up on #371
signupsDisabledcurrently just disables signups on the backend, but the signup link is still visible and you can still try to signup until you see the error message. So this is mostly a cosmetic / UX PR:Expose
signupsDisabledon the publicGET /configendpoint so the dashboard can reflect the API'sDISABLE_SIGNUPSenv flag.Pure UX patch. Does not change the signup endpoint's existing behavior (200 with success:false when disabled) and exposes only the signup-disabled flag - no secrets or admin-only env state.
Type of Change
feat:New feature (MINOR version bump)fix:Bug fix (PATCH version bump)feat!:Breaking change - new feature (MAJOR version bump)fix!:Breaking change - bug fix (MAJOR version bump)docs:Documentation update (no version bump)chore:Maintenance/dependencies (no version bump)refactor:Code refactoring (no version bump)test:Adding tests (no version bump)perf:Performance improvement (PATCH version bump)Testing
Setting
DISABLE_SIGNUPSand then visiting /auth/signup and /auth/login (see screenshots above)Checklist
Related Issues
#371