Honor configured and recorded health contracts - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teploy healthused the default automatic probe regardless of the app's configured health mode or path. An HTTP-only app could therefore report healthy after an HTTP 404 if its TCP port accepted a connection.Use the manifest's mode, path and timing for local commands. For
--app, use the current release's recorded contract and refuse an unavailable contract with actionable guidance. Preserve published-address detection.Validation: full
go vet ./...,go test ./..., and CLI build passed. Focused regressions prove HTTP failures cannot fall back to TCP, custom readiness paths and timing are retained, TCP-only checks avoid HTTP, and unavailable release contracts are refused.Synchronizes the Forgejo tree at
2bef926into the GitHub mirror. No release tag or deployment.