Skip to content

fix[backend](correlation_rules): fixed correlation rules disappearing… #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSanchez-bit merged 1 commit into from
Sep 2, 2026
Merged

fix[backend](correlation_rules): fixed correlation rules disappearing… #2525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions backend/modules/eventprocessing/usecase/correlation_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,16 @@ func (u *correlationRuleUsecase) Update(ctx context.Context, req dto.UpdateCorre
if req.RelPath == "" {
return domain.ErrIDRequired
}
if err := u.writable(ctx, req.RelPath); err != nil {
sr, err := u.readable(ctx, req.RelPath)
if err != nil {
return err
}
if sr.System {
return domain.ErrCorrelationRuleSystemOwner
}
if tenant := authz.TenantIDFromContext(ctx); tenant != "" && sr.TenantId != tenant {
return domain.ErrCorrelationRuleNotFound
}
if len(req.DataTypes) == 0 {
return domain.ErrDataTypesRequired
}
Expand All @@ -149,12 +156,12 @@ func (u *correlationRuleUsecase) Update(ctx context.Context, req dto.UpdateCorre
req.RuleAvailability, req.RuleCategory, req.RuleTechnique, req.RuleDescription,
req.RuleReferencesDef, req.RuleDefinitionDef, correlate, req.RuleGroupByDef,
req.DeduplicateByDef, req.DataTypes)
rule.TenantId = sr.TenantId

if _, err := u.store.Update(req.RelPath, rule); err != nil {
return err
}
// Reconcile the active state (the store keeps it in the filename).
_, err := u.store.SetEnabled(authz.TenantIDFromContext(ctx), req.RelPath, req.RuleActive)
_, err = u.store.SetEnabled(sr.TenantId, req.RelPath, req.RuleActive)
return err
}

Expand Down
Loading