Skip to content

threatintelligense/fallback - #2573

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_threatintelligense_fallback
Sep 10, 2026
Merged

AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_threatintelligense_fallback

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

…ds data when no instance ioc matches can be found
@AlexSanchez-bit AlexSanchez-bit linked an issue Sep 10, 2026 that may be closed by this pull request
3 tasks
@github-actions

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

⚠️ architecture (gemini-3-flash-lite) — minor findings

Summary: Frontend threat-intel search hook handles not found errors with a fallback request, adding an empty result kind.

  • medium frontend/src/features/threat-intel/hooks/use-ti-search-advanced.ts:13 — Fallback request sends an empty object {} as AdvancedSearchRequest on a 404 error. Ensure that threatIntelHttpService.searchAdvanced properly supports an empty body request type to avoid type mismatches or unexpected backend validation errors.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Mutation fallback sends empty object instead of input body, and empty state is never reset on subsequent successful searches.

  • high frontend/src/features/threat-intel/hooks/use-ti-search-advanced.ts:13 — When caught error is NotFound, the fallback calls searchAdvanced with an empty object {} instead of the original input.body, discarding the user's advanced search filters.
  • medium frontend/src/features/threat-intel/pages/ThreatIntelPage.tsx:116 — The empty state is set to true when data.kind === 'empty', but is never reset back to false on subsequent successful searches where data.kind === 'ok', causing stale empty states to persist.

security (gemini-3-flash-lite) — clean

Summary: Added empty state handling for advanced threat intelligence searches.

No findings.

🔴 go-deps — pending updates

🔍 Discovered 30 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/soc-ai:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/shared:
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/feeds:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0
     - golang.org/x/sync: v0.22.0 → v0.23.0

  📁 ./plugins/sophos:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/bitdefender:
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/soar:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/stats:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/azure:
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.0 → v1.8.1
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/alerts:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./plugins/geolocation:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/o365:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.46.0 → v1.47.0
     - github.com/aws/aws-sdk-go-v2/config: v1.33.3 → v1.33.4
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.3 → v1.20.4
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.86.0 → v1.87.0

  📁 ./plugins/gcp:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/crypto: v0.56.0 → v0.57.0

  📁 ./plugins/rule-flood-guard:
     - github.com/threatwinds/go-sdk: v1.1.27-0.20260811073440-251cb9d842cd → v1.1.31

  📁 ./backend:
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.0 → v1.8.1
     - github.com/aws/aws-sdk-go-v2/config: v1.33.3 → v1.33.4
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.3 → v1.20.4
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.49.0 → v1.50.0
     - github.com/golang-migrate/migrate/v4: v4.19.1 → v4.20.1
     - github.com/jackc/pgx/v5: v5.10.0 → v5.11.0
     - golang.org/x/crypto: v0.56.0 → v0.57.0
     - golang.org/x/oauth2: v0.36.0 → v0.37.0
     - golang.org/x/sync: v0.22.0 → v0.23.0
     - golang.org/x/sys: v0.47.0 → v0.48.0

  📁 ./agent-manager:
     - golang.org/x/sync: v0.22.0 → v0.23.0

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.31
     - golang.org/x/sys: v0.47.0 → v0.48.0

❌ Please update dependencies before merging.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

not found means there's no user indicators on threatwinds so empty body means fallback to default threatwinds response

@AlexSanchez-bit
AlexSanchez-bit merged commit b64ec63 into release/v12.0.0 Sep 10, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_threatintelligense_fallback branch September 10, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v12 Threat Intelligence

1 participant