Skip to content

Support domains 2.x#45

Merged
ChiragAgg5k merged 1 commit into
mainfrom
chore/support-domains-2
May 13, 2026
Merged

Support domains 2.x#45
ChiragAgg5k merged 1 commit into
mainfrom
chore/support-domains-2

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented May 13, 2026

Summary

  • Bump utopia-php/domains to ^2.0.
  • Refresh composer.lock for the domains 2.x dependency graph.

Testing

  • composer validate

Notes

  • This unblocks consumers upgrading to the latest Utopia cache stack through domains 2.x.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR updates the utopia-php/domains constraint in composer.json from 1.0.* to ^2.0 and regenerates composer.lock. The stated goal is to support domains 2.x while preserving 1.x compatibility, but the implementation only satisfies the first half of that goal.

  • composer.json: The new ^2.0 constraint exclusively requires domains 2.x, dropping 1.x support entirely. If the intent is dual compatibility (as the PR description states), the constraint should be 1.0.* || ^2.0.
  • composer.lock: The regenerated lock file goes well beyond a content-hash refresh — utopia-php/cache jumps a major version (1.0.0 → 2.1.0), a new transitive dependency utopia-php/circuit-breaker 0.3.0 is introduced, and several other packages receive minor/patch bumps.

Confidence Score: 4/5

The constraint change drops domains 1.x support entirely, contradicting the stated goal — this needs to be resolved before merging.

The ^2.0 constraint makes utopia-php/domains 1.x an incompatible peer, so any consumer still on 1.x who upgrades this package will encounter a Composer conflict. The PR description explicitly says 1.x compatibility is preserved, meaning either the constraint or the description needs correction.

composer.json — the domains constraint should be revisited to confirm whether 1.x support is intentionally dropped or needs to be retained alongside 2.x.

Important Files Changed

Filename Overview
composer.json Changed utopia-php/domains constraint from 1.0.* to ^2.0, which drops 1.x compatibility entirely — contradicting the PR description's claim of dual 1.x/2.x support.
composer.lock Multiple transitive dependency bumps beyond just the content hash: utopia-php/cache 1.0.0→2.1.0 (major), new utopia-php/circuit-breaker 0.3.0, and several minor/patch upgrades across open-telemetry, symfony, and other packages.

Reviews (2): Last reviewed commit: "Support domains 2.x" | Re-trigger Greptile

Comment thread composer.json Outdated
@ChiragAgg5k ChiragAgg5k force-pushed the chore/support-domains-2 branch from e1d0de4 to 8c0b494 Compare May 13, 2026 05:00
Comment thread composer.json
@ChiragAgg5k ChiragAgg5k merged commit 90bf1bc into main May 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants