Skip to content

Fix PHP 8.5 curl_close() deprecation#67

Merged
lohanidamodar merged 1 commit into
mainfrom
fix/clo-4293-curl-close-php85
May 3, 2026
Merged

Fix PHP 8.5 curl_close() deprecation#67
lohanidamodar merged 1 commit into
mainfrom
fix/clo-4293-curl-close-php85

Conversation

@lohanidamodar
Copy link
Copy Markdown
Contributor

@lohanidamodar lohanidamodar commented May 3, 2026

Summary

  • Remove no-op \curl_close($ch) calls in Orchestration\Adapter\DockerAPI that trigger Deprecated notices on PHP 8.5.

Why

curl_close() has been a no-op since PHP 8.0 and is now formally deprecated in 8.5. The curl handle is freed when the variable goes out of scope.

Test plan

  • composer lint (Pint) — pass
  • composer check (PHPStan L6) — pass

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 3, 2026

Greptile Summary

Removes two curl_close($ch) calls from DockerAPI::call() and DockerAPI::streamCall() that have been no-ops since PHP 8.0 and are now formally deprecated in PHP 8.5. The curl handles are correctly freed when they go out of scope, so this is a safe cleanup with no behavioral change.

Confidence Score: 5/5

This PR is safe to merge — it removes deprecated no-op calls with no behavioral impact.

The change is minimal and correct: curl_close() has been a documented no-op since PHP 8.0, and PHP 8.5 formalises the deprecation. Removing the calls does not affect resource management since the curl handles are freed on scope exit. No logic, error handling, or control flow is altered.

No files require special attention.

Important Files Changed

Filename Overview
src/Orchestration/Adapter/DockerAPI.php Removed two no-op curl_close($ch) calls from call() and streamCall() methods to fix PHP 8.5 deprecation notices; no logic changes.

Reviews (1): Last reviewed commit: "Remove deprecated curl_close() calls (PH..." | Re-trigger Greptile

@lohanidamodar lohanidamodar merged commit 4458950 into main May 3, 2026
7 checks passed
@lohanidamodar lohanidamodar deleted the fix/clo-4293-curl-close-php85 branch May 3, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants