Add queue depth telemetry gauge#79
Conversation
Greptile SummaryThis PR introduces a
Confidence Score: 5/5Safe to merge — the change is additive, guarded by an interface check, and does not alter any existing message-processing behavior. The gauge is always initialized (constructor calls setTelemetry(new NoTelemetry())) so no uninitialized-property risk exists. The instanceof Publisher guard ensures nothing changes for consumers that do not support getQueueSize(). The finally-block placement means queue depth is captured after every message without interfering with the success/error callback flow. All three behavioral paths are covered by the new test. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Simplify queue depth error telemetry" | Re-trigger Greptile |
Summary
messaging.queue.depthgauge initialized with the queue server telemetry.Publisher::getQueueSize().Type of Change
Testing
vendor/bin/phpunit tests/Queue/E2E/Adapter/ServerTelemetryTest.phpvendor/bin/phpstan analyse src/Queue/Server.php tests/Queue/E2E/Adapter/ServerTelemetryTest.php --memory-limit=1Gvendor/bin/pint --test src/Queue/Server.php tests/Queue/E2E/Adapter/ServerTelemetryTest.phpFull
vendor/bin/phpunitwas attempted locally, but the AMQP E2E tests require theamqp:5672service hostname and failed DNS resolution outside the Docker test environment.