sort: use locale_cmp when all selectors have equal ordering#13350
Open
lauchimoon wants to merge 2 commits into
Open
sort: use locale_cmp when all selectors have equal ordering#13350lauchimoon wants to merge 2 commits into
lauchimoon wants to merge 2 commits into
Conversation
Merging this PR will degrade performance by 11.73%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | sort_numeric[500000] |
1 s | 1.4 s | -26.32% |
| ❌ | Simulation | sort_key_field[500000] |
767 ms | 836.9 ms | -8.36% |
| ❌ | Simulation | sort_case_insensitive[500000] |
251.6 ms | 268.9 ms | -6.42% |
| ❌ | Simulation | sort_dictionary_order[500000] |
1 s | 1.1 s | -3.92% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing lauchimoon:numeric-fix (de6f5a2) with main (cd80f63)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13319.
When all selectors return
Ordering::Equalincompare_by, the last resort was to use byte-by-byte comparison, ignoring the locale.The change now resorts to use
locale_cmpifi18n-collatoris enabled.