Get 'test' working properly with acls and supplementary groups by jefft · Pull Request #9149 · uutils/coreutils

jefft · 2025-11-05T15:01:41Z

Fixes #8960 and #9147. Delegate to libc euidaccess to avoid bugs (#9147) and respect ACLs (#8960).

Note, the tests are independent commits that can be applied first, where they should fail before the 'fix' commit is applied. Run the tests with:

cargo test --test tests test_permission_with_acl
cargo test --test tests test_permission_with_supplementary_group

Warning: code is partly Claude-generated as I'm not that familiar with Rust.

codspeed · 2025-11-05T15:25:30Z

Merging this PR will degrade performance by 3.7%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 279 untouched benchmarks
⏩ 38 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Memory	`dd_copy_default`	130 KB	124.8 KB	+4.17%
❌	Memory	`du_wide_tree[(5000, 500)]`	1.2 MB	1.3 MB	-3.7%

_{Comparing jefft:fix/8960-9147-test-work-with-acls-and-supplementary-groups (e3d63d7) with main (4bfbbdd)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-11-05T15:34:59Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

sylvestre

dunno if you saw it but many jobs are failing, this is why it hasn't been reviewed yet

github-actions · 2025-12-28T09:49:08Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-io-err was skipped on 'main' but is now failing.

github-actions · 2025-12-28T14:02:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/assert is no longer failing!

github-actions · 2026-01-17T06:25:43Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-18T12:02:38Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-18T13:43:40Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-19T06:20:00Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

sylvestre · 2026-01-19T07:51:22Z

it is still marked as draft :)

…ls#9147 Run with: cargo test --test tests test_permission_with_supplementary_group

Run with: cargo test --test tests test_permission_with_acl

Replace manual permission checking logic with platform-specific libc functions that properly handle supplementary groups and ACLs: - Linux, Hurd, Redox, Cygwin, Solaris, Illumos: euidaccess() - FreeBSD: eaccess() - macOS, iOS, NetBSD, OpenBSD, DragonFly: faccessat() with AT_EACCESS - Android: faccessat() - Other OSes: fall back to libc:access() These functions delegate permission checks to the kernel, which correctly evaluates all of the user's group memberships (both primary and supplementary), as well as ACLs and other advanced permission features. Fixes uutils#8960 Fixes uutils#9147

jefft · 2026-01-19T08:08:16Z

Soo many tests..

I think a few tests are flakey, e.g. whatever caused the last failure (https://github.com/uutils/coreutils/actions/runs/21120355090), and I've rebased my patch just to trigger a fresh run. I think I've addressed all the actual PR defects (failure on sudo-less environments, fmt and clippy violations). I'll un-draft this PR once tests are passing.

github-actions · 2026-01-19T08:17:46Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

jefft · 2026-01-19T09:29:41Z

I think this PR is good to review now, despite 2 failing checks:

Android Test builds (ubuntu-latest, 4, 4096, 28, google_apis_playstore, x86) failed, but if one inspects the Android action it's been failing for everyone recently:

..and it wasn't failing prior to my recent rebase.
The Codspeed regression comes and goes over various commits, and I can't see that it's related to my change. No doubt the ACL checks do add some overhead, but that's unavoidable.

anastygnome · 2026-10-01T17:47:07Z

Superseded by #14966

anastygnome · 2026-10-03T12:58:01Z

@cakebaker can you close this as fixed in the last test PR

sylvestre requested changes Dec 26, 2025

View reviewed changes

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch from d56a7d6 to e06edcb Compare December 28, 2025 04:53

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch 2 times, most recently from a7881d7 to dc664b3 Compare December 29, 2025 12:20

jefft marked this pull request as draft December 30, 2025 07:31

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch 2 times, most recently from 24c7c88 to 72aa2ee Compare January 17, 2026 04:57

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch 2 times, most recently from f8a5524 to 7fbfd9f Compare January 18, 2026 11:07

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch from 7fbfd9f to 7302d2d Compare January 18, 2026 13:30

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch from 7302d2d to a32b3fd Compare January 18, 2026 23:18

jefft added 6 commits January 19, 2026 18:55

test: Check that 'test' takes supplementary groups into account. uuti…

b0091ec

…ls#9147 Run with: cargo test --test tests test_permission_with_supplementary_group

test: Check that 'test' respects ACLs. uutils#8960

a51c571

Run with: cargo test --test tests test_permission_with_acl

test: Merge uutils#8960 and uutils#9147 tests.

c132004

test: redox libc does not have euidaccess

f59d7ea

test: get tests working in sudo-less environments

e3d63d7

jefft force-pushed the fix/8960-9147-test-work-with-acls-and-supplementary-groups branch from a32b3fd to e3d63d7 Compare January 19, 2026 07:56

jefft marked this pull request as ready for review January 19, 2026 09:17

jefft requested a review from sylvestre January 19, 2026 09:17

cakebaker closed this Oct 3, 2026

Conversation

jefft commented Nov 5, 2025

Uh oh!

codspeed Bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 3.7%

Performance Changes

Footnotes

Uh oh!

github-actions Bot commented Nov 5, 2025

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 28, 2025

Uh oh!

github-actions Bot commented Dec 28, 2025

Uh oh!

github-actions Bot commented Jan 17, 2026

Uh oh!

github-actions Bot commented Jan 18, 2026

Uh oh!

github-actions Bot commented Jan 18, 2026

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

sylvestre commented Jan 19, 2026

Uh oh!

jefft commented Jan 19, 2026

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

jefft commented Jan 19, 2026

Uh oh!

anastygnome commented Oct 1, 2026

Uh oh!

anastygnome commented Oct 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codspeed Bot commented Nov 5, 2025 •

edited

Loading