Skip to content

grep: pin onig_sys instead of a wildcard version - #112

Merged
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:fix-onig-sys-wildcard
Aug 27, 2026
Merged

grep: pin onig_sys instead of a wildcard version#112
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:fix-onig-sys-wildcard

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 27, 2026 18:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing sylvestre:fix-onig-sys-wildcard (1fea766) with main (2ff48db)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@lhecker lhecker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW how do you tell Cargo to just use whatever dependency version another dependency already got? Like, how could we say "use whatever onig-sys version onig already uses"? I was hoping "*" would achieve that.

@sylvestre

Copy link
Copy Markdown
Contributor Author

Cargo publish refuses that. He wants an explicit version

@sylvestre
sylvestre merged commit 87fb973 into uutils:main Aug 27, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants