fix: find slotted children via ComponentUtil.getAllChildren - #142
Merged
Conversation
The locator only walked component.children plus virtual children, so components a component excludes from getChildren() (Card slots, Dialog header/footer on 25.3) were not found. Union the reported children with ComponentUtil.getAllChildren, which walks the element tree (regular and virtual children, descending through non-component wrappers) regardless of any getChildren() override, and keep component.children so children held outside the element tree (ContextMenu items in MenuManager) stay reachable.
mcollovati
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to vaadin/flow-components#9280
Related to vaadin/flow-components#9743
Replaces #89
Added usage of
ComponentUtil.getAllChildren()helper to handle components that filter out non-default content fromgetChildren()- particularly,CardandDialog(the latter was changed in 25.3 alpha - see PR above).Type of change