feat: add setAutoFocus to dialog, deprecate setFocusTrap - #9799
Draft
vursen wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
vursen
marked this pull request as draft
July 27, 2026 12:50
|
web-padawan
reviewed
Jul 27, 2026
| * otherwise | ||
| * @since 25.3 | ||
| */ | ||
| public boolean isAutoFocus() { |
Member
There was a problem hiding this comment.
question: should we rename to isAutofocus() to align with existing components?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
setAutoFocusmethod to Dialog that controls whether focus should automatically move into the dialog's overlay on open, and deprecatessetFocusTrapin its favor. Disabling auto focus also disables the focus trap in modal dialogs, as the trap can't activate without focus moving inside.Related to vaadin/web-components#12237
Fixes vaadin/web-components#11971