Skip to content

chore: remove unused Tokens convenience wrappers #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theredspoon wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

chore: remove unused Tokens convenience wrappers #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions internal/core/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,8 @@ func NewFile(src string, config *Config) (*File, error) {
return &file, nil
}

// Tokens returns the tagged tokens of text, tagging it only once per document
// however many rules ask for it.
func (f *File) Tokens(text string) []tag.Token {
toks, _ := f.TokensWith("", text)
return toks
}

// TokensWith is Tokens, read with the named tagger.
// TokensWith returns the tagged tokens of text, read with the named tagger,
// tagging it only once per document however many rules ask for it.
//
// Two models disagree about the same sentence -- that is why a rule names
// one -- so each is cached separately.
Expand Down
9 changes: 2 additions & 7 deletions internal/nlp/prose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,8 @@ type TokenCache struct {
tagged map[string][]tag.Token
}

// Tokens returns the tagged tokens of text, tagging it only the first time.
func (c *TokenCache) Tokens(text string, info *Info) []tag.Token {
toks, _ := c.TokensWith("", text, info)
return toks
}

// TokensWith is Tokens, read with the named tagger.
// TokensWith returns the tagged tokens of text, read with the named tagger,
// tagging it only the first time.
func (c *TokenCache) TokensWith(model, text string, info *Info) ([]tag.Token, error) {
if c == nil {
return textToTokensWith(model, text, info)
Expand Down