fix(isISO6346): anchor full pattern and drop stray comma#2773
Open
Noethix55555 wants to merge 1 commit into
Open
fix(isISO6346): anchor full pattern and drop stray comma#2773Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
The regex /^[A-Z]{3}(U[0-9]{7})|([J,Z][0-9]{6,7})$/ did not group the
alternation, so ^ anchored only the first branch and $ only the second.
The first branch matched any string starting with the owner prefix, U and
7 digits while ignoring trailing characters; the second matched any string
ending with J/Z and 6-7 digits while ignoring the leading owner prefix.
[J,Z] also accepted a literal comma. Strings whose length is not 11 skip
the checksum and return true, so these malformed inputs passed.
Group the alternation inside the anchors and use [JZ].
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2587
Branches 656 656
=========================================
Hits 2587 2587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2772.
The regex in
src/lib/isISO6346.jsdid not group the alternation, so^anchored only the first branch and$only the second. The first branch matched any string starting with the owner prefix,Uand 7 digits while ignoring trailing characters; the second matched any string ending withJ/Zand 6-7 digits while ignoring the leading owner prefix.[J,Z]also accepted a literal comma. Strings whose length is not 11 skip the checksum and returntrue, so these malformed inputs passed.The fix groups the alternation inside the anchors and uses
[JZ]:All existing valid and invalid fixtures still pass. Added the four cases above to the invalid fixtures for both
isISO6346andisFreightContainerID; they fail on the previous regex and pass with the fix.