Fix parsing arrays with a name that's a prefix of an existing array - #8
Open
ramzes642 wants to merge 2 commits into
Open
Fix parsing arrays with a name that's a prefix of an existing array#8ramzes642 wants to merge 2 commits into
ramzes642 wants to merge 2 commits into
Conversation
Author
|
Fixed one more corner-case with nested array |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have two arrays where the name of the second one is a prefix of the first, like this:
[[fruits]]
name = "banana"
[[fruit]] # prefix of existing array
name = "strawberry"
The library throws an "key duplication" error even though this is valid. If you swap the order of these items, the issue doesn't occur.
This is caused by a missing . in the str_starts_with check in TomlKeystore::addArrayTableNode.
I added that missing dot, added it to the success test and also added a test that verifies that invalid toml is still rejected by this check.