fix(rust): skip scanning dirs that can't match - #85
Open
nik9000 wants to merge 1 commit into
Open
Conversation
Modifies the `find_oaths` rust internals to skip scanning directories that can't possibly can't match. This speeds up my usage which wants to scan the repo root to pick up oaths from the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
What this changes
Modifies the
find_oathsrust internals to skip scanning directories that can't possibly can't match. This speeds up my usage which wants to scan the repo root to pick up oaths from the README.How you verified it
Verified locally by
make rust.make checkfails, see #84.Also verified the performance boost by using it on my project locally.