Fix non-persistent search configuration#822
Closed
o3wiz wants to merge 1 commit into
Closed
Conversation
Author
|
@variar Hi can you take a look at this P.R? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a compilation/runtime issue where search colors (for mainBackColor and quickfindBackColor) were not being correctly loaded from storage when building against Qt versions newer than 6.4.0.
In Qt > 6.4.0, the codebase incorrectly attempted to chain .fromString() as if it were a non-static setter mutating an existing object, similar to how .setNamedColor() behaves in older Qt versions. However, QColor::fromString() is a static factory method that returns a new QColor instance.
This PR fixes the logic by properly assigning the return value using the assignment operator (= QColor::fromString(...)), ensuring the retrieved configuration is actually persisted into the configuration object.
Fixes #821