Skip to content

Bring fork back in sync with upstream while preserving Dell recovery support - #2

Merged
vartaxe merged 3 commits into
mainfrom
copilot/update-fork-with-original-repo
Aug 31, 2026
Merged

vartaxe merged 3 commits into
mainfrom
copilot/update-fork-with-original-repo

Conversation

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown

The fork had drifted behind the upstream project and needed a clean sync without losing the Dell-specific recovery-image behavior introduced by the fork. This merge brings the branch back in line with upstream/main while preserving the forced-download and forced-flash logic required for Dell NVMe BIOS recovery recreation after reimaging.

  • Summary

    • Synced the fork with the current upstream main branch.
    • Resolved merge conflicts across the BIOS package and BIOS update scripts.
    • Kept the fork’s Dell recovery workflow intact without reverting upstream fixes.
  • Changes

    • Updated README.md to reflect the upstream project while documenting the fork’s Dell recovery-image workflow.
    • Merged the current upstream version of Invoke-CMDownloadBIOSPackage.ps1 and retained the opt-in force-download behavior needed for Dell NVMe recovery-image recreation.
    • Preserved compatibility with both the legacy SMSTSForceDellBIOSFlash task sequence variable and the newer SMSTSForceBIOSDownload alias.
    • Kept the Dell-specific /f logic in Invoke-DellBIOSUpdate.ps1 enabled when explicitly requested, while staying aligned with the upstream script behavior.
  • Example

# Task sequence pattern for Dell NVMe recovery image recreation
Set Task Sequence Variable
  Name:  SMSTSForceDellBIOSFlash
  Value: True

Invoke-CMDownloadBIOSPackage.ps1 ...
Invoke-DellBIOSUpdate.ps1 -Force

maurice-daly and others added 3 commits August 21, 2026 14:44
Co-authored-by: vartaxe <11176349+vartaxe@users.noreply.github.com>
@vartaxe
vartaxe marked this pull request as ready for review August 31, 2026 20:59
Copilot AI lite review requested due to automatic review settings August 31, 2026 20:59
@vartaxe
vartaxe merged commit 6c927e5 into main Aug 31, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README currently overstates SMSTSForceBIOSDownload behavior and the newly added legacy script disables TLS certificate validation unconditionally.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR syncs the fork with current upstream changes while keeping (and documenting) the Dell NVMe recovery-image recreation workflow, including opt-in “force download” behavior so a same-version BIOS re-application can be staged for a subsequent forced flash.

Changes:

  • Updated README.md to reflect upstream and describe the fork’s Dell recovery-image workflow and TS variables.
  • Updated Invoke-CMDownloadBIOSPackage.ps1 to v3.0.6, including refined force-download handling and a fix for model matching in live task sequences.
  • Added Invoke-CMDownloadBIOSPackage_Legacy.ps1 as a legacy copy of the older implementation.
File summaries
File Description
README.md Documents the fork’s Dell recovery-image workflow and related task-sequence variables.
Invoke-CMDownloadBIOSPackage.ps1 Brings the downloader script in sync with upstream and adds/clarifies opt-in force-download behavior.
Invoke-CMDownloadBIOSPackage_Legacy.ps1 Introduces a legacy script version for reference/compatibility.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md
```

The single TS variable enables both the forced download and the forced flash.
A single task-sequence variable enables both the forced download and forced flash. The more general `SMSTSForceBIOSDownload` is also accepted.
@@ -1246,9 +1250,13 @@ Process {
Write-CMLogEntry -Value "BIOS is already up to date with the latest $($PackageList[0].PackageVersion) version" -Severity 1
Comment on lines +115 to +116
# SSL Certificate Validation Workaround
[System.Net.ServicePointManager]::ServerCertificateValidationCallback = {$true}
@vartaxe

vartaxe commented Aug 31, 2026

Copy link
Copy Markdown
Owner

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

@vartaxe
vartaxe deleted the copilot/update-fork-with-original-repo branch September 13, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants