Bring fork back in sync with upstream while preserving Dell recovery support - #2
Conversation
Co-authored-by: vartaxe <11176349+vartaxe@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The README currently overstates SMSTSForceBIOSDownload behavior and the newly added legacy script disables TLS certificate validation unconditionally.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR syncs the fork with current upstream changes while keeping (and documenting) the Dell NVMe recovery-image recreation workflow, including opt-in “force download” behavior so a same-version BIOS re-application can be staged for a subsequent forced flash.
Changes:
- Updated
README.mdto reflect upstream and describe the fork’s Dell recovery-image workflow and TS variables. - Updated
Invoke-CMDownloadBIOSPackage.ps1to v3.0.6, including refined force-download handling and a fix for model matching in live task sequences. - Added
Invoke-CMDownloadBIOSPackage_Legacy.ps1as a legacy copy of the older implementation.
File summaries
| File | Description |
|---|---|
| README.md | Documents the fork’s Dell recovery-image workflow and related task-sequence variables. |
| Invoke-CMDownloadBIOSPackage.ps1 | Brings the downloader script in sync with upstream and adds/clarifies opt-in force-download behavior. |
| Invoke-CMDownloadBIOSPackage_Legacy.ps1 | Introduces a legacy script version for reference/compatibility. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ``` | ||
|
|
||
| The single TS variable enables both the forced download and the forced flash. | ||
| A single task-sequence variable enables both the forced download and forced flash. The more general `SMSTSForceBIOSDownload` is also accepted. |
| @@ -1246,9 +1250,13 @@ Process { | |||
| Write-CMLogEntry -Value "BIOS is already up to date with the latest $($PackageList[0].PackageVersion) version" -Severity 1 | |||
| # SSL Certificate Validation Workaround | ||
| [System.Net.ServicePointManager]::ServerCertificateValidationCallback = {$true} |
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
The fork had drifted behind the upstream project and needed a clean sync without losing the Dell-specific recovery-image behavior introduced by the fork. This merge brings the branch back in line with
upstream/mainwhile preserving the forced-download and forced-flash logic required for Dell NVMe BIOS recovery recreation after reimaging.Summary
mainbranch.Changes
README.mdto reflect the upstream project while documenting the fork’s Dell recovery-image workflow.Invoke-CMDownloadBIOSPackage.ps1and retained the opt-in force-download behavior needed for Dell NVMe recovery-image recreation.SMSTSForceDellBIOSFlashtask sequence variable and the newerSMSTSForceBIOSDownloadalias./flogic inInvoke-DellBIOSUpdate.ps1enabled when explicitly requested, while staying aligned with the upstream script behavior.Example