Skip to content

Normalize PowerShell line endings in VM support changes - #4

Merged
vartaxe merged 1 commit into
masterfrom
copilot/fetch-and-merge-from-upstream
Aug 31, 2026
Merged

vartaxe merged 1 commit into
masterfrom
copilot/fetch-and-merge-from-upstream

Conversation

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown

Recent virtual-machine support additions used CRLF endings that Git interpreted as trailing whitespace.

  • Line-ending cleanup
    • Normalize line endings on the 52 affected additions in Invoke-CMApplyDriverPackage.ps1.
    • Preserve existing script content and avoid a whole-file rewrite.

Co-authored-by: vartaxe <11176349+vartaxe@users.noreply.github.com>
@vartaxe
vartaxe marked this pull request as ready for review August 31, 2026 21:33
Copilot AI lite review requested due to automatic review settings August 31, 2026 21:33
@vartaxe
vartaxe merged commit 5e3cda5 into master Aug 31, 2026
1 check passed
@vartaxe
vartaxe deleted the copilot/fetch-and-merge-from-upstream branch August 31, 2026 21:34
Copilot stopped work on behalf of vartaxe due to an error August 31, 2026 21:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The file still contains mixed line endings (CRLF and LF), so the intended whitespace/normalization cleanup is not yet consistently applied and may continue to cause diffs/whitespace-check noise.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR aims to clean up line-ending issues introduced in recent virtual-machine support additions to Invoke-CMApplyDriverPackage.ps1, so Git no longer reports whitespace problems while keeping the script’s behavior unchanged.

Changes:

  • Normalizes formatting/line-ending-related diffs across the recently added VM support sections (help examples, -AllowVirtualMachine parameter block, VM detection/filtering helpers, and version log line).
  • Keeps functional script content the same while limiting the scope of the rewrite.
File summaries
File Description
Invoke-CMApplyDriverPackage.ps1 Line-ending/whitespace normalization in the VM support-related additions and nearby lines.
Review details

Copilot wasn't able to review any files in this pull request.

  • Files reviewed: 0/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 375 to +379
# Enable TLS 1.2 support for downloading modules from PSGallery
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
$Script:IsVirtualMachine = $false
$Script:VirtualMachineModels = @("Virtual Machine", "VMware Virtual Platform", "VirtualBox", "HVM domU", "KVM", "VMware7,1")
$Script:VirtualMachinePackagePattern = "\b(virtual machine|vmware|vmxnet|pvscsi|hyper[- ]?v|parallels|virtualbox|virtio|kvm|xen)\b"
$Script:IsVirtualMachine = $false
$Script:VirtualMachineModels = @("Virtual Machine", "VMware Virtual Platform", "VirtualBox", "HVM domU", "KVM", "VMware7,1")
$Script:VirtualMachinePackagePattern = "\b(virtual machine|vmware|vmxnet|pvscsi|hyper[- ]?v|parallels|virtualbox|virtio|kvm|xen)\b"
@vartaxe

vartaxe commented Aug 31, 2026

Copy link
Copy Markdown
Owner

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants