Repository navigation
Compare benchmarks against the base branch on pull requests - #38
Merged
veewee merged 1 commit intoOct 15, 2026
Merged
Conversation
Same setup as php-soap/encoding: benchmark the base branch, store it as a baseline and report the pull request against it. It only reports, it does not fail on a difference, because runner noise is larger than most changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pull request now gets a phpbench comparison against its base branch, using the same setup as php-soap/encoding: the base branch is benchmarked and stored as a baseline, then the pull request is reported against it.
The job only reports. It does not fail on a difference, because the noise on shared runners is larger than most of the changes it would catch.
This is stacked on #37, which adds phpbench and the benchmarks. Merge #37 first; until then main has no benchmarks for the baseline step to run. Against #37 as its base, this PR already shows the comparison working.