Skip to content

feat(domain): add the tutor event-envelope tracer - #16

Open
phibkro wants to merge 1 commit into
publish/0011-homepage-localfrom
publish/0014-tutor-tracer
Open

feat(domain): add the tutor event-envelope tracer#16
phibkro wants to merge 1 commit into
publish/0011-homepage-localfrom
publish/0014-tutor-tracer

Conversation

@phibkro

@phibkro phibkro commented Aug 12, 2026

Copy link
Copy Markdown
Member

Design spec

design-specs/0014-tutor-event-envelope-tracer.md

Journey

A maintainer runs a deterministic tutor lifecycle tracer that decodes commands, accepts lawful transitions, rejects stale or illegal transitions, and emits replayable envelopes and receipts.

Experience it

  1. Check out this stacked branch.
  2. Run the focused package commands recorded in the spec.
  3. Inspect accepted and rejected transition evidence and two-run byte identity.

Evidence

  • Focused build, typecheck, lint, and proof gates: PASS.
  • Independent code/runtime review: PASS.
  • Exact eight-path capsule including the final spec.

What is real

The in-memory command/event/receipt seam is executable and deterministic. It does not claim D1 persistence, Worker routing, scheduling semantics, provider behavior, deployment, or production acceptance.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac694c0413

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +8 to +10
const Rfc3339Schema = Schema.String.check(
Schema.isPattern(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/),
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate calendar values in RFC 3339 timestamps

For event input such as 2026-99-99T99:99:99Z, this pattern succeeds even though the value is not a valid RFC 3339 timestamp. Consequently decodeEventEnvelopeV1 accepts malformed dates and foldEvents may order them lexicographically as legitimate events, violating the tracer's fail-closed input boundary; validate the parsed calendar date and time rather than only their digit shape.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant