feat(dashboard): migrate applicant assignment to the SDK seam - #20
feat(dashboard): migrate applicant assignment to the SDK seam#20phibkro wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeee2c66a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| context: "options" as const, | ||
| }), | ||
| ), | ||
| client.admin.interviews.schemas().then( |
There was a problem hiding this comment.
When this route runs against the repository's server, every call here fails decoding: InterviewSchemaListProvider returns InterviewSchemaResource objects containing id, name, and questionCount, while admin.interviews.schemas() requires each object to contain a questions array (packages/sdk/src/schemas/interview.ts). Because the loader treats this options failure as fatal, authorized users receive “Kunne ikke laste intervjualternativer” instead of any applicant table, so this seam needs to consume a contract compatible with the current /api/admin/interview-schemas response.
Useful? React with 👍 / 👎.
| } | ||
| }); | ||
|
|
||
| await resetStub(request); |
There was a problem hiding this comment.
The newly auto-discovered test unconditionally contacts 127.0.0.1:8789 here, but the checked apps/dashboard/playwright.config.ts starts only the dashboard server and, in fixture mode, the login fixture on port 8788; neither test:e2e nor e2e:test starts e2e/fixtures/applicant-api.ts. Consequently a normal package Playwright run fails immediately with a connection error unless a developer happens to launch the bespoke stub externally, so the test must arrange that server itself or be excluded from the default suite.
Useful? React with 👍 / 👎.
1 participant
Design spec
design-specs/0018-dashboard-applicant-assignment-sdk-seam.mdJourney
An authorized dashboard user loads applicant queues, assigns an interviewer and school through the typed SDK seam, observes exact typed failures, and gets fail-closed behavior for malformed or unknown application status.
Experience it
Evidence
What is real
The dashboard-to-SDK applicant assignment seam, typed error projection, and fail-closed unknown-status UI are locally functional with synthetic data. This does not prove backend persistence, auth-provider behavior, production data, deployment, or production acceptance.