Repository navigation
Order only timers in the promisified timers test - #1167
Merged
Merged
Conversation
ctate
commented
Oct 17, 2026
ctate
commented
Collaborator
- 5628 compared a 1 ms timer with an immediate, whose order varies with loop timing in Node too (7 of 128 loaded Node runs differed); it now orders three timers, which settle in deadline order.
5628-promisify-timers.ts compared a 1 ms timer with an immediate armed at the same time. Their order depends on how much time has passed when the loop reaches its timers phase: once the delay has elapsed, the timer fires before the check phase. Node prints either order under load. The test now orders three timers armed together (1, 10 and 30 ms), which settle in deadline order. The node-types fixture does the same with two timers.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.