Repository navigation
Conversation
Contributor
|
@blurname is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
blurname
marked this pull request as ready for review
October 17, 2026 06:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1170.
Widening
Result<T, never>toResult<T, E>(and the symmetric error-only result) currently fails because the unreachable payload uses the numeric placeholder and is checked as an inhabited record arm.Track uninhabited record arms as part of union identity and preserve that information through optionality and union transformations. The existing retag planner can then trap an impossible arm instead of requiring an incompatible payload conversion. Keep the original layout so unreachable branch reads still compile; an inhabited alternative sharing the same storage layout prevents that arm from being marked impossible.
Regression coverage includes both result variants, arguments and returns, nested records and arrays, intersection records, optional
never,never[], never-returning callbacks/accessors, storage-identity collisions, and IR validation/serialization. The differential fixture runs against Node in release and dev modes.Validation on macOS arm64 with Node 24.22.0:
type-mapper-unions.test.ts,union-retag.test.ts, andvalidate.test.tspass; the new differential fixture passes in release/dev and plain/ASan+RC-audit modes.Full-gate status: not green. A full local plain run was stopped after the existing WASI test
the LLVM target embeds compressed npm sources and builtin shimsfailed withBuffer.concat of 'unknown' values(SC2020,zlibzoo/index.js:52). The identical failure reproduces with all affected compiler sources loaded from the unchanged base1b34b4069a235d4d911783cb652fcd87e3bd5db0and caches disabled. The full sanitized lane has not completed; the targeted sanitized regressions listed above pass. No test is disabled or changed to hide this baseline failure.The two fixes are on independent branches; the full-gate attempt included both, while focused validation was also run on each standalone branch.