Repository navigation
Conversation
Contributor
|
@blurname is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
blurname
marked this pull request as ready for review
October 17, 2026 06:25
Collaborator
|
Thanks for this. #1209 landed the same fix (plus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1171.
Fixed tuples currently reject
filter,find,findIndex, andsomeeven though the corresponding array operations and other tuple read methods compile. Add native tuple predicate helpers using the existing IR and callback/type-narrowing machinery.The helpers evaluate the receiver and callback once, read each position when visited, preserve the value observed before a callback mutates that position, and short-circuit the search methods. Empty tuples return the appropriate empty/missing result without invoking the callback. Existing tuple boundaries remain explicit for
thisArg, spread arguments, the callback's array parameter, and unsupported asserted narrowing.Differential coverage checks readonly and mixed tuples, empty tuples, inferred narrowing, Boolean/truthiness predicates, callback mutation, receiver/argument evaluation order, reference identity, exceptions, and generic consumers. Negative compiler tests also verify that a previously cached inferred-narrowing helper does not admit an explicitly asserted predicate.
Validation on macOS arm64 with Node 24.22.0:
tuple-callback-visitation.tsalso pass with ASan and the RC audit.Full-gate status: not green. A full local plain run was stopped after the existing WASI test
the LLVM target embeds compressed npm sources and builtin shimsfailed withBuffer.concat of 'unknown' values(SC2020,zlibzoo/index.js:52). The identical failure reproduces with all affected compiler sources loaded from the unchanged base1b34b4069a235d4d911783cb652fcd87e3bd5db0and caches disabled. The full sanitized lane has not completed; the targeted sanitized regressions listed above pass. No test is disabled or changed to hide this baseline failure.The two fixes are on independent branches; the full-gate attempt included both, while focused validation was also run on each standalone branch.