fix: respect components.json alias for install path#440
Open
gianpieropuleo wants to merge 1 commit into
Open
Conversation
shadcn's resolveAliasTarget only activates when the target starts with `@aliasKey/`. Plain `components/ai-elements/...` bypasses alias resolution and writes to `<project-root>/components/ai-elements/` regardless of how `components.json` is configured. Prefixing targets with `@components/` lets shadcn resolve the destination through the `components` alias, so projects that remap it (e.g. to `@/lib/components`) get files installed in the right place.
Contributor
|
@gianpieropuleo is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing ai-elements ignores the
componentsalias incomponents.json, always writing files to<project-root>/components/ai-elements/regardless of how the project is configured.Re-addresses #44, which was closed after PR #46 removed the
targetfield, but commit 1c23c11 ("Add targets") reintroduced it shortly after, bringing the bug back.Root cause
shadcn's
resolveAliasTargetonly activates when atargetstarts with@aliasKey/. A plaincomponents/ai-elements/...target bypasses alias resolution entirely and is treated as a literal path relative to the project root.Fix
Prefix all
targetvalues with@components/so shadcn resolves the destination through thecomponentsalias incomponents.json:"components": "@/components") ->components/ai-elements/✓"components": "@/lib/components") ->lib/components/ai-elements/✓components.json-> shadcn runs init first, then the default alias applies ✓Why not just remove
target?PR #46 tried this. The problem: without
target, shadcn callsresolveNestedFilePath(path, targetDir)which looks for the last segment of the resolved components dir (e.g."components") inside the file'spathstring (registry/default/ai-elements/conversation.tsx). No match is found, so it falls back to just the filename, and files would land atlib/components/conversation.tsxinstead oflib/components/ai-elements/conversation.tsx.