Persist /clear by deleting chat messages - #1550
Open
ShobhanKarthish wants to merge 1 commit into
Open
ShobhanKarthish wants to merge 1 commit into
ShobhanKarthish wants to merge 1 commit into
Conversation
Clear previously only emptied client state, so the next /api/chat request rebuilt model context from DB history and a refresh restored old messages. Delete persisted messages (and related votes/streams) for the chat, update the messages cache, and keep the same chat id. Closes vercel#1549
Contributor
|
@ShobhanKarthish is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/clearonly calledsetMessages([]), so the next/api/chatrequest still loaded DB history into model context and a refresh restored the old UI.chatId, keeping the same chat. Optimistic UI + SWR cache update stay aligned with DB.app/(chat)/api/chat/route.tsalready rebuilds context from DB messages, so no route change is required once history is deleted (chosen over starting a new chat id as the smaller product behavior).Test plan
/clear, confirm the UI is emptytests/e2e/clear-chat.test.ts(mocks DELETE/api/messages)Closes #1549