Update LaunchDarkly Flags SDK template for Marketplace integration#1525
Open
Andrewjeska wants to merge 5 commits into
Open
Conversation
Andrewjeska
requested review from
dominiksipowicz,
goncy,
lfades,
lpalmes and
okbel
as code owners
Andrewjeska
changed the title
Contributor
|
@Andrewjeska is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Andrewjeska
force-pushed
the
launchdarkly/manderjaska/REL-13054-update-template-for-marketplace
branch
from
289a8ec to
6289a25
Compare
Andrewjeska
commented
Jul 1, 2026
Author
There was a problem hiding this comment.
I think this is just the linter
Contributor
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
Andrewjeska
commented
Jul 1, 2026
| * This adapter supports two ways of reading LaunchDarkly flags, and picks one | ||
| * automatically based on which environment variables are present: | ||
| * | ||
| * 1. Edge Config mode (`EDGE_CONFIG` or `EXPERIMENTATION_CONFIG`, plus |
Author
There was a problem hiding this comment.
This template originally had EDGE_CONFIG, probably the connected account integration expected that env var. let me know what's the preferred env var now.
Andrewjeska
commented
Jul 1, 2026
Comment on lines
+120
to
+124
| 2. Generate a `FLAGS_SECRET` yourself instead of relying on the deploy prompt: | ||
|
|
||
| ```bash | ||
| node -e "console.log(crypto.randomBytes(32).toString('base64url'))" | ||
| ``` |
Author
There was a problem hiding this comment.
I'm not too familiar, can you just do this?
Andrewjeska
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
flags-sdk/launchdarklyexample to work cleanly with the LaunchDarkly integration on the Vercel Marketplace.EXPERIMENTATION_CONFIG)LAUNCHDARKLY_SDK_KEY), no Edge Config required. Addslib/launchdarkly-adapter.ts..env.examplerewritten to explain which vars the integration injects vs. which you set, both modes, and a manual-setup path (including generatingFLAGS_SECRET).Testing
pnpm build/ local dev in both Edge Config and server SDK modes.