Update Node runtimes to v24 - #479
Open
AlexJSully wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The vscode-docker image switches to the NodeSource v24 channel but does not pin an exact Node version, which can cause rebuild drift and reduce the intended cross-environment alignment.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Workbench devcontainer templates, container images, and Flatcar VM startup installation path to use Node.js v24 (targeting v24.19.0 where feasible) to reduce runtime drift across build and execution environments.
Changes:
- Bump devcontainer Node feature versions across templates to
24.19.0. - Upgrade the Flatcar startup Node install to
v24.19.0and update the corresponding SHA-256 verification. - Move Playground and extension-builder base image references to updated/pinned image digests; switch
vscode-dockerto the NodeSource v24 channel.
File summaries
| File | Description |
|---|---|
| startupscript/butane/010-install-node.sh | Updates Flatcar VM Node version to v24.19.0 and refreshes the SHA-256 check. |
| src/workbench-jupyter-with-llm/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/workbench-jupyter-parabricks/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/vscode/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/vscode-with-llm/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/vscode-docker/Dockerfile | Switches NodeSource setup script from 22.x to 24.x for Node installation. |
| src/virtual-browser-rstudio/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/virtual-browser-jupyter/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/r-analysis/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/playground/playground/Dockerfile | Pins Playground runtime stage to the official Node 24.19.0 Alpine image + digest and removes redundant Node APK install. |
| src/nemo_jupyter/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/jupyter-common/extension-builder/Dockerfile | Updates extension-builder base image digest. |
| src/custom-workbench-jupyter-template/.devcontainer.json | Bumps devcontainer Node feature version to 24.19.0. |
| src/aou-common/extension-builder/Dockerfile | Updates extension-builder base image digest. |
| feature-versions/state.json | Updates the tracked installed digest for the extension-builder base image. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
68
to
71
| # Install Node.js (required for promptfoo) | ||
| RUN curl -fsSL https://deb.nodesource.com/setup_22.x | bash - && \ | ||
| RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - && \ | ||
| apt-get install -y nodejs && \ | ||
| rm -rf /var/lib/apt/lists/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Node environments used by Workbench applications to Node v24, using v24.19.0 wherever exact versions are supported. This aligns Node across Workbench workspace templates, runtime images, extension builds, and startup installation paths, reducing environment-specific differences.
Rationale:
v24.17.0andv24.18.1security releases, including fixes affecting TLS, WebCrypto, HTTP/2 & the permission model.v24.18.0increases Node’s default Buffer pool from 8 KiB to 64 KiB; see Node’s eight-worker benchmark.This PR includes the following changes:
vscode-dockerfrom the NodeSource v22 channel to the v24 channel.