Replace Triton HTTP with gRPC#56
Open
yfan-viant wants to merge 1 commit into
Open
Conversation
dchoi-viant
reviewed
Nov 10, 2025
| Models: | ||
| - ID: my_triton_model | ||
| Platform: triton | ||
| URL: http://localhost:8001 # or https://triton-server:8001 |
Contributor
There was a problem hiding this comment.
Minor: This should be corrected to reflect how the system actually works and should work.
dchoi-viant
reviewed
Nov 10, 2025
| return evaluator | ||
| } | ||
|
|
||
| func parseGRPCAddress(url string) string { |
Contributor
There was a problem hiding this comment.
Note to self: this behavior is a bit confusing at the risk of convenience?
dchoi-viant
reviewed
Nov 10, 2025
|
|
||
| **Configuration Fields:** | ||
| - `Platform`: Set to `"triton"` to enable Triton backend | ||
| - `URL`: Triton server HTTP endpoint (will be converted to gRPC port 8001) |
Contributor
There was a problem hiding this comment.
Minor: this wording "will be converted" is a bit confusing, or I have uncertainty of how it will be "converted."
Contributor
There was a problem hiding this comment.
Minor: add "see below" or similar.
dchoi-viant
reviewed
Nov 10, 2025
|
|
||
| **URL Format:** | ||
| - HTTP URL is automatically converted to gRPC endpoint | ||
| - `http://localhost:8000` → `localhost:8001` (gRPC) |
Contributor
There was a problem hiding this comment.
Major: This is incorrect - this does not happen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Triton HTTP with gRPC
E2E tests all passed