[DRAFT] Implemented time range skipping - #7966
Closed
krseager wants to merge 2 commits into
Closed
Conversation
Collaborator
|
I'm not interested in taking +1,995 -22 change for this as a feature. Once we land Client-side Interstitials API you could insert an interstitial with a resumption offset that doesn't have a resolving asset. The failure would skip over the interstitial range for both buffering and playback. The interstitialsManager would give you the visibility you want into buffer length and timeline, excluding ranges. If this is something you'd be interested in, we could look at ensuring support for "empty" interstitials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Implements a feature to enable HLS.js to expose an API to ignore buffering certain time ranges and a config value to specify a tolerance for excluding segments that have start/end times near one of these ranges. Defaults to 0.1 seconds.
The application provides a list of start and end times. This could represent movie/tv show intro, already watched ad breaks, end credits, etc. it can also be used for when a user seeks past an ad break, but the application forces the user to watch the ad, then seeks back to the requested playback position.
This significantly cuts down on the amount of buffering the user would see when seeking these time ranges, as we’re able to load media further ahead of the playhead position.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Depending on feedback, I will create an issue for this.
Checklist