Repository navigation
fix(parser): strip apostrophes from queue names - #175
Closed
ertugrulkutluer wants to merge 1 commit into
Closed
ertugrulkutluer wants to merge 1 commit into
ertugrulkutluer wants to merge 1 commit into
Conversation
Queue building names were only stripped of spaces, so "Hero's Mansion" became "Hero'sMansion" and failed to parse as BuildingEnums.HerosMansion, stopping the bot with "Cannot parse Hero'sMansion. Is language English ?". Strip straight and typographic apostrophes too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
this was fixed in #173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildingLayoutParser.GetQueueBuildingonly removed spaces from the building name, so a queued Hero's Mansion becameHero'sMansion.UpdateBuildingCommand.IsValidQueueBuildingcould not parse that asBuildingEnums.HerosMansionand stopped the bot:The game was already in English. The same would happen for any other building name containing an apostrophe.
Fix
Also strip straight (
') and typographic (’) apostrophes when cleaning the queue name.Testing
Passed