Skip to content

Probable bug with unintentionally reenabled animations if they was disabled before #3

Description

@krypt-lynx

This fragment disables UIView animations (UIView.setAnimationsEnabled(false)) and enables them back assuming they should be enabled

https://github.com/vitkuzmenko/StructureKit/blob/28a33ea9c40610b6c944e5af743d0a253464875b/Sources/StructureKit/StructureController/StructureController%2BUICollectionView.swift#L64C54-L64C54

But actually they may be not. The proper way would be to read the old value using UIView.areAnimationsEnabled and restoring it back instead of unconditionally enabling animations

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions