gui: support text input scrolling and rich text rise - #68
Merged
dy-tea merged 1 commit intoJul 1, 2026
Conversation
dy-tea
approved these changes
Jul 1, 2026
dy-tea
left a comment
Member
There was a problem hiding this comment.
lgtm, tests also run fine on my linux system.
Contributor
Author
|
@dy-tea Thanks for your feedback! |
GGRei
force-pushed
the
fix/issues-57-51-text-input-rise-20260701
branch
from
July 1, 2026 15:54
9c66bca to
5b6248f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for two GUI text improvements:
Fix #57
Fix #51
Codex validation : here
Details
Single-line inputs now keep their overflow state private to the input control and apply it through text geometry. This keeps icons, wrappers, and outer layouts stable while allowing caret reveal, selection, hit-testing, IME placement, and rendering to use the same horizontal text offset.
Rich text styling now forwards baseline rise values so markdown superscript/subscript and direct rich text runs render with the expected vertical offset.
Validation
VMODULES=/tmp/vgui_vmodules_official VJOBS=2 v test .70 passed, 1 skipped, 71 totalv fmt -verify ...git diff --checkv -os windows -check