Skip to content

fix(validation): tie closure lifetimes to Semantic #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 1 commit into from
Oct 16, 2026
Merged

fix(validation): tie closure lifetimes to Semantic #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/oxc_angular_compiler/src/validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,19 @@ fn namespace_import_of<'a>(
/// in `ns.f.required`) only when `ns` resolves to a namespace import of the
/// module. Any other binding — a parameter, a local, an unrelated import —
/// means the call isn't one of the API's.
fn is_api_reference(callee: &Expression<'_>, api: InitializerApi, semantic: &Semantic<'_>) -> bool {
fn is_api_reference<'a>(
callee: &Expression<'a>,
api: InitializerApi,
semantic: &Semantic<'a>,
) -> bool {
// `f` — its binding must be the import.
let named = |expr: &Expression<'_>| {
let named = |expr: &Expression<'a>| {
let Expression::Identifier(id) = expr else { return false };
direct_import_of(id, semantic)
.is_some_and(|(module, name)| module == api.1 && name == api.0)
};
// `ns.f` — `ns` must be a namespace import of the module.
let namespaced = |expr: &Expression<'_>| {
let namespaced = |expr: &Expression<'a>| {
let Expression::StaticMemberExpression(member) = expr else { return false };
let Expression::Identifier(ns) = &member.object else { return false };
member.property.name == api.0 && namespace_import_of(ns, semantic) == Some(api.1)
Expand Down
Loading