Repository navigation
fix(void): avoid rewriting unchanged generated files - #215
Merged
Merged
Conversation
❌ Deploy Preview for staging-void-cloud failed.
|
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
…ype (#215) * fix(dispatch): serve correct content-type for .md and re-derive stored octet-stream Add md/markdown/yaml/yml/toml to the MIME table, and treat a stored application/octet-stream as unknown so it is re-derived from the path at serve time. Content-addressed assets are never re-uploaded, so this heals already-deployed files (e.g. viteplus.dev .md pages) without a redeploy. * refactor(dispatch): fold application/null sentinel into resolveAssetContentType Return string | undefined from the resolver so the 'omit Content-Type header' decision lives in one place, collapsing the three duplicated `contentType !== 'application/null'` guards at the call sites to a plain `if (contentType)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was a bit surprised when my MacBook turned hot after a while of running multiple VS Code windows with Void apps.
The reason is that Void rn rewrites tsconfigs again even if the content is the same, triggering other extensions such as Tailwind.
This PR only rewrites the file when the content actually changes.
(Netlify CI fails due to the site being on void)