Skip to content

fix(deploy): include worker vars in prepared artifacts - #574

Merged
cpojer merged 1 commit into
voidzero-dev:mainfrom
dvkam:fix/529-artifact-worker-vars
Oct 26, 2026
Merged

cpojer merged 1 commit into
voidzero-dev:mainfrom
dvkam:fix/529-artifact-worker-vars

Conversation

@dvkam

@dvkam dvkam commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #529.

prepareDeployArtifact() drops worker.vars from the returned deployment manifest. Forward the configured vars through the existing manifest builder, matching managed CLI deployments.

Regression coverage checks configured values and empty strings, omission of missing or empty maps, assets-only output, and exclusion of dotenv and generated Wrangler vars.

Validation

  • The new regression failed before the fix. All 10 artifact-preparation tests pass afterward.
  • A real local build packaged through void/deploy preserves the configured vars with zero preparation fetch calls.
  • Formatting, lint, builds, artifact checks, workspace typechecking, and npm/pnpm installed-package smoke checks pass.
  • The full run passed 733 test files and skipped one. The Astro suite exceeded its 20-second startup limit; all 8 Astro tests passed in isolation with the original timeout.

@dvkam
dvkam marked this pull request as ready for review October 24, 2026 14:15

@cpojer cpojer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer
cpojer merged commit ef60343 into voidzero-dev:main Oct 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prepareDeployArtifact omits worker.vars that the CLI managed deploy includes

2 participants