Repository navigation
fix(pages): exclude private helpers from the client entry decision - #603
Merged
cpojer merged 1 commit intoOct 27, 2026
Merged
Conversation
dvkam
marked this pull request as ready for review
October 26, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #575.
An ordinary component inside
pages/_ui/caused React and Solid to buildpages-client, even when every page used islands.That entry imported page modules into the browser.
Use the existing production page scan to decide whether the app needs
pages-client.Remove the separate file checks in both adapters.
Private helpers and named layouts no longer cause this entry.
Ordinary pages still include it.
Explicit islands inside private directories still hydrate.
The scan also applies production file selection and exact island suffix rules to this decision.
Invalid routes can now fail during build configuration, before
buildStart.Add unit checks for private paths, custom page roots, ordinary pages, file suffixes, production file selection, and scan errors.
Add production build tests for React and Solid.
These tests check the client manifest, server HTML, CSS, and client JavaScript.
They also click an explicit private Counter island in Chromium.
Validation: