Repository navigation
fix(router): reject HEAD exports and give each route file its own loader name - #612
Merged
Brooooooklyn merged 2 commits intoOct 27, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-router-head-and-loader-names-void-cloud.voidzero-docs.workers.dev (commit 8665f77)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Brooooooklyn
force-pushed
the
fix/router-head-and-loader-names
branch
from
October 27, 2026 07:54
dd20f96 to
580d966
Compare
A route file that exported HEAD made the generated route module call app.head(), which Hono does not have. The module threw on load, so every request to the app failed in dev and in the deployed Worker. Hono already answers HEAD requests with the GET handler, so a HEAD handler could never run anyway. Route scanning now stops with a clear error that names the file and says to remove the HEAD export. The server routing guide notes that GET also answers HEAD. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generated route module named each loader after its file path with every character other than an ASCII letter or digit turned into "_". Two route files such as api/user-list.ts and api/user_list.ts, or two page files whose non-ASCII names have the same length (blog/你好.md and blog/世界.md), produced the same const twice. The module then failed to parse with "Identifier has already been declared", which broke dev and build. Loader and markdown head names now come from one name map per kind. A name that would repeat gets a numeric suffix, and the prerender path collector uses the same names as the page routes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/router-head-and-loader-names
branch
from
October 27, 2026 08:05
580d966 to
8665f77
Compare
Brooooooklyn
enabled stacked auto-merge (squash)
October 27, 2026 08:34
stacked auto-merge was automatically disabled
October 27, 2026 08:34
Auto-merge was disabled for another pull request in the stack
fengmk2
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two separate mistakes could each make the generated route module (
virtual:void-routes) fail to load. When that happens, every request fails, in dev and in production.export const HEADin a route file. The compiler wroteapp.head(...), but Hono has noheadmethod, so the module threw on load. Hono already answers HEAD requests with the GET handler._. Soapi/user-list.tsandapi/user_list.ts, orblog/你好.mdandblog/世界.md, declared the sameconsttwice (SyntaxError).What changed
router/scan.ts: route scanning stops with a clear error that names the file when it exportsHEAD.router/compile.ts: newcreateIdentifierNames()helper. It keeps the old cleaned-up name and adds_2,_3, ... only when a name would repeat. Route loaders use one map. Page loaders, markdown head functions and the prerender path collector share a second map.docs/guide/server-routing.md: one line sayingGETalso answersHEAD.Two commits: the HEAD fix first, then the loader names.
Tests
api/user-list.ts+api/user_list.tscompile, and the output parses with oxc semantic checks on..mdpages and two CJK server pages (one prerendered) get their own names, and the prerender collector calls the same loader as the page route.Choices to check
componentId, which is already unique per page, so existing names such as_pload_indexstay the same.🤖 Generated with Claude Code