Repository navigation
fix(cli): send queue maxRetries and retryDelay on managed deploys - #614
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-managed-queue-retries-void-cloud.voidzero-docs.workers.dev (commit d6900fc)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
511fb0d to
d85c1c9
Compare
💡 Codex Reviewvoid/packages/void/src/auth/config.ts Lines 104 to 105 in d85c1c9 For apps with an auth config, AGENTS.md reference: packages/void/AGENTS.md:L169-L169 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A queue file could set `export const maxRetries = 0` or `export const retryDelay = 30`, but a Void-managed `void deploy` left both out of the deploy manifest. The platform then created the queue consumer with Cloudflare's defaults (3 retries, no delay), so consumers that asked for no retries were still retried. The managed manifest now includes both options when they are set, keeping 0 as a real value, the same as native Cloudflare deploys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d85c1c9 to
d6900fc
Compare
|
Fixed in 106d132 on #611, which this PR is stacked on. |
Auto-merge was disabled for another pull request in the stack
Problem
A queue file can set
export const maxRetries = 0orexport const retryDelay = 30. On a Void-managedvoid deploy, both settings were left out of the deploy manifest, so the platform created the consumer with Cloudflare's defaults (3 retries, no delay). A consumer that asked for no retries was still retried.What changed
toManifestSchedulesAndQueuesinpackages/void/src/cli/deploy-helpers.tsnow copiesmaxRetriesandretryDelaywhen they are set. It uses!= null, so0is kept. Native Cloudflare deploys already did this.Tests
New unit test in
packages/void/test/unit/deploy-project.test.ts:maxRetries: 0andretryDelay: 30appear in the manifest.The test fails without the fix. It also fails if the check becomes truthy (so 0 is dropped), or if
retryDelayis always written.Choices to check
🤖 Generated with Claude Code